<html>
<head><meta charset="utf-8"><title>serde doc runs broken · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/serde.20doc.20runs.20broken.html">serde doc runs broken</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="226918085"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/serde%20doc%20runs%20broken/near/226918085" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/serde.20doc.20runs.20broken.html#226918085">(Feb 19 2021 at 04:08)</a>:</h4>
<p>Looks like feature gating linking to associated items of raw pointers is breaking serde on perf.rlo at least - cc <span class="user-mention" data-user-id="232545">@Joshua Nelson</span> </p>
<p>I'll note it in my to-do list to fix tomorrow in rustc-perf.</p>



<a name="226918182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/serde%20doc%20runs%20broken/near/226918182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/serde.20doc.20runs.20broken.html#226918182">(Feb 19 2021 at 04:09)</a>:</h4>
<p>oh ugh they re-exported an item from core and the feature-gate checks the active crate, not the original crate</p>



<a name="226918233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/serde%20doc%20runs%20broken/near/226918233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/serde.20doc.20runs.20broken.html#226918233">(Feb 19 2021 at 04:10)</a>:</h4>
<p>I think the right behavior is probably to only check the original crate</p>



<a name="226918242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/serde%20doc%20runs%20broken/near/226918242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/serde.20doc.20runs.20broken.html#226918242">(Feb 19 2021 at 04:10)</a>:</h4>
<p>as a workaround you can remove the link in core and use manual links</p>



<a name="226918671"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/serde%20doc%20runs%20broken/near/226918671" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/serde.20doc.20runs.20broken.html#226918671">(Feb 19 2021 at 04:19)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/82284">https://github.com/rust-lang/rust/issues/82284</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>